search

galatolofederico / manim-presentation

Tool for live presentations using manim
GNU General Public License v3.0
162 stars 18 forks source link

Windows fullscreen fix #19

Closed jeertmans closed 1 year ago

jeertmans commented 2 years ago

This proposes a small fix to the problem where full-screen resolution is bad. Apparently, this only occurs in Windows platforms. Tested on Windows 10 & Ubuntu 22.04. The solution is mostly a copy / paste from here.

Even though, the fix is not a perfect fix and quality is still not as good as with Ubuntu. For instance, I had to render in p or even k quality on Windows to have a result similar to h quality on Ubuntu.

As mentioned in #15, I am working on a separate fork on which I did other improvements, and many more improvements are still ongoing. Maybe we could merge both works later, or I can keep me work separate as it implies some major changes in the codebase. Anyway, this is not the point of this PR :-)

Closes #15.

galatolofederico commented 2 years ago

Yes i just saw your repo, nice work! If you plan to continue working/support your fork i will deprecate this repo and link to yours

jeertmans commented 2 years ago

Thanks! Yes indeed I plan to continue working on my fork for at least a few months on personal features I would like to add, then I would also love to implement / fix bugs raised by the community.

jeertmans commented 1 year ago

I close this due to inactivity, and I already implemented this fix, as well as new features on Manim Slides.