Closed linusheck closed 3 years ago
Again, if this doesn't work for you, don't merge it :) I'm happy with this as my fork that I will use :D
Hey i like the new state machine there seems to be two issues:
I'll merge into a new branch and i'll try to fix those problems
Also the loops seems to stop after the first iteration. For now i will leave it to you :sweat_smile:
"the animations stop 1 frame before the actual last frame" I think this happened before... The state machine is not really new, I kinda changed yours, but I don't know if it completely makes sense yet.
Thanks for the comments! I will look into them.
Hey, I think I fixed pause & loops. The problem with the not really last frame is not mine, but this is so in manim exports in general. One solution would be showing the first frame on the next slide on WAIT (see commented code), but this fails if there is a clear() directly after pause() of course.
Thanks it works fine! i just re added the add_last_slide()
function in 1cc070db86656f31d69adfa12f4805121f7d2a66 because it was not working if the last slide was a loop
Merged! i will merge the keybindings branch and i will tag a new version! thanks for your work!
Thanks it works fine! i just re added the
add_last_slide()
function in 1cc070d because it was not working if the last slide was a loop
This reintroduced the issue that you can't run scenes behind another, because the last slide doesn't have a corresponding video.
Also, I thought the Wait() for one frame in pause() is a good idea. For which reason did you remove it? :D
Because it is not needed with the add_last_slide()
. Or this is was my understanding reading the code. The video of the last slide is the last animation of the current video
See #5.