galaxy-genome-annotation / python-apollo

Python library for talking to Apollo API
MIT License
11 stars 11 forks source link

added bulk load gff3 #29

Closed nathandunn closed 4 years ago

nathandunn commented 4 years ago

nathandunn commented 4 years ago

Thanks. I'll see where I get by the end of the day . . .if @abretaud has a chance to review it great. Worst-case we could always re-patch it if needed.

nathandunn commented 4 years ago

@abretaud I am going to add some timing code and reduce the verbosity a little bit, but nothing more. At some point (lateR) this will get expanded, so the method pulling attributes off of the gff3 to put in JSON may get bigger.

nathandunn commented 4 years ago

But it is still ready for review.

nathandunn commented 4 years ago

Note @abretaud it still isn't loading the legacy_gff3 properly . . . I'll try to fix that prior to a merge.

nathandunn commented 4 years ago

@abretaud Okay, I fixed the legacy load stuff.

nathandunn commented 4 years ago

@abretaud if it looks good, I would say go ahead and merge it and publish it (not entirely sure how to publish it)

abretaud commented 4 years ago

@nathandunn I have a few comments pending + making some tests, still working on it ;)

nathandunn commented 4 years ago

@nathandunn I have a few comments pending + making some tests, still working on it ;)

Awesome thanks!

nathandunn commented 4 years ago

Just as an FYI @abretaud load_legacy_gff3 produces errors for me so I removed it form the bootstrap_apollo.sh script if that is okay.

nathandunn commented 4 years ago

I meant . . it produced errors for me in the upgraded server.

hexylena commented 4 years ago

amazing, super improvement :)