Closed nathandunn closed 4 years ago
Thanks. I'll see where I get by the end of the day . . .if @abretaud has a chance to review it great. Worst-case we could always re-patch it if needed.
@abretaud I am going to add some timing code and reduce the verbosity a little bit, but nothing more. At some point (lateR) this will get expanded, so the method pulling attributes off of the gff3 to put in JSON may get bigger.
But it is still ready for review.
Note @abretaud it still isn't loading the legacy_gff3 properly . . . I'll try to fix that prior to a merge.
@abretaud Okay, I fixed the legacy load stuff.
@abretaud if it looks good, I would say go ahead and merge it and publish it (not entirely sure how to publish it)
@nathandunn I have a few comments pending + making some tests, still working on it ;)
@nathandunn I have a few comments pending + making some tests, still working on it ;)
Awesome thanks!
Just as an FYI @abretaud load_legacy_gff3 produces errors for me so I removed it form the bootstrap_apollo.sh script if that is okay.
I meant . . it produced errors for me in the upgraded server.
amazing, super improvement :)
batch-size
an optionadd_one_feature
, and fix testsadd_tarnscripts and move
add_one_transcript` and fix teststest
disable_cds
use_name