search

galaxycomputationalchemistry / galaxy-tools-compchem

:mega: Galaxy Tools for Computational Chemistry
Apache License 2.0
14 stars 16 forks source link

[do not merge] Version Autoupdate #93

Closed planemo-autoupdate closed 3 years ago

planemo-autoupdate commented 3 years ago

Autoupdate conda package versions

simonbray commented 3 years ago

@bgruening here is an example PR from the bot @lorrainealisha75 has written. The GH action is here: https://github.com/planemo-autoupdate/autoupdate/blob/main/.github/workflows/update.yml

Let us know if you have any comments or ideas

simonbray commented 3 years ago

This is super cool! This PR looks very good. I have a few general question:

* will https://github.com/galaxycomputationalchemistry/galaxy-tools-compchem/pull/93/files#diff-408f112caf3a5fdb7b87d143cac65747f86b0b5f3cae19f0d0a47431cc719b1bR5 also be reset to 0 if it is >0?

Yes, see for example https://github.com/galaxycomputationalchemistry/galaxy-tools-compchem/pull/93/files#diff-ab743fdd6926c9ffe8fd6e5436c1f733be23fdfe4b8180e2e9bcea6d99fbae60R5.

* can/should we open single PRs for single tools?

Probably this is indeed a better option.

simonbray commented 3 years ago
  • can/should we open single PRs for single tools?

Probably this is indeed a better option.

Complicated because of macros - one per directory is probably doable.

bgruening commented 3 years ago

Complicated because of macros - one per directory is probably doable.

This is what I meant. One per tool-suite or however we call it.