search

galaxyproject / ansible-cvmfs

An Ansible role for installing and configuring CernVM-FS (CVMFS)
12 stars 17 forks source link

Ungalaxyification #5

Closed natefoo closed 6 years ago

natefoo commented 6 years ago

Make this a more generic role that does not automatically configure Galaxy CVMFS repos by default (but retain a single config option to enable them) to make this more suitable for uploading to Ansible Galaxy for general consumption.

afgane commented 6 years ago

LGTM, perhaps just a bit of documentation in the README for general consumption as well?

hexylena commented 6 years ago

Maybe we could consider hiding the galaxy values behind a flag of some sort? (I don't want to have to diff my variables against some text in the readme or a file every time I pull in a newer version of this module.)

natefoo commented 6 years ago

@afgane That's the plan, it's the main reason it's still WIP. That and it's untested.

@erasche Not sure I follow. This puts them behind galaxy_cvmfs_repos_enabled.

hexylena commented 6 years ago

@natefoo I'm blind. I missed that, sorry. I guess I saw the deletion of the old servers variable and didn't remember that that variable wasn't being consumed anyway and I'd already filed an issue about that.

hexylena commented 6 years ago

Fixes https://github.com/galaxyproject/ansible-cvmfs/issues/3

natefoo commented 6 years ago

The last few changes are untested but I think this is nearly ready.

hexylena commented 6 years ago

Tested on a machine, client role works fine