search

galaxyproject / ansible-galaxy-tools

An Ansible role for automated installation of tools from a Tool Shed into Galaxy.
MIT License
14 stars 34 forks source link

Fix ansible syntax and pin ansible to 2.7.4 #58

Closed drosofff closed 5 years ago

drosofff commented 5 years ago

My two cents for the ansible code synthax. In addition, I propose to pin ansible to 2.7.4, because this is also the version installed when using apt in trusty, which should insure more interoperability with docker image build on ubunty:14.04 and loaded with ansible using apt.

I suggest that this is done with all ansible repos of the galaxyproject, to make life easier. But I am of course aware that migration of code for compatibility with ansible 2.7.4 may take some efforts.

I'll next work on ansible-galaxy-os because it is in some case the first layer of docker images. Thus I really think that pining ansible version deserve effort

afgane commented 5 years ago

I agree that pinning a version across all the ansible repos is likely the most convenient thing to from the usability standpoint. But potentially a lot of work when that version needs to be bumped...