search

galaxyproject / ansible-galaxy-tools

An Ansible role for automated installation of tools from a Tool Shed into Galaxy.
MIT License
14 stars 34 forks source link

adapt manage_bootstrap_user.py to change in lib/galaxy/web/security introduced in Galaxy release_19.05 #61

Closed drosofff closed 5 years ago

drosofff commented 5 years ago

see changes here https://github.com/galaxyproject/galaxy/commit/528497f7c42f81d4114eeccc559ad16366c423dd

The fix allows successfully bootstrapping a user in release_19.05 and preserves backward compatibility with < release_19.05

bgruening commented 5 years ago

@drosofff I think there is a 19.05 branch. If you want to apply it to this one. I will merge 19.05 as soon as the release is out.

drosofff commented 5 years ago

Hi @bgruening It's late I am sleepy: applying what ? ;-)

bgruening commented 5 years ago

Oh, lol, no I'm sleepy all good. I thought that's the bootstrap script in ansible-extras :) Uha. going to bed now :)

drosofff commented 5 years ago

Too many ansible roles ? ;-) Have a good night, I am going to bed too

monprin commented 5 years ago

Is there an estimate for when this may be merged into master?

I am using this role in the deployment I am developing and would like to be able to use it with the most recent release.

drosofff commented 5 years ago

Hi @bgruening Any chance to get this PR reviewed ? I think @monprin would be as happy as me ! Chris

drosofff commented 5 years ago

Hi, @nuwang @afgane @mvdbeek you all three contributed to this code. Could you please help in resolving this PR ? This is required to accommodate the 19_05 galaxy release in GalaxyKickStart, as well as with this specific playbook of course. Thanks for your help, the PR is opened since May 24th

mvdbeek commented 5 years ago

Thanks @drosofff!