Use molecule for testing

galaxyproject / ansible-galaxy-tools

An Ansible role for automated installation of tools from a Tool Shed into Galaxy.

MIT License

14 stars 34 forks source link

Use molecule for testing #73

Closed dometto closed 6 months ago

bernt-matthias commented 6 months ago

Can you explain in more detail what you are doing here?

Would be cool to restore testing as a github actions workflow (https://github.com/galaxyproject/ansible-galaxy-tools/blob/master/.travis.yml).

dometto commented 6 months ago

Hi @bernt-matthias! This is work in progress, I'd like to use this role to automate the import of certain toolfiles and workflows, but it needs to be updated for more recent ansible versions. To do that I wanted to extend the tests, and I'm using molecule for that. My idea is to take the galaxy-min Docker image as a base, add a bootstrap api key to that, and use that to test this role.

Happy to create a GH actions workflow for the molecule tests once they are done and contribute back!

dometto commented 6 months ago

Oh, I just noticed that I opened this PR against the origin repo instead of against my own fork! :-D Sorry about that. I can close this and reopen when it's ready for review, if you're interested in the molecule tests.

dometto commented 2 months ago

@bernt-matthias sorry for accidentally having opened this PR and some others against this repo. I was doing some work refactoring this role over at https://github.com/dometto/ansible-galaxy-tools. I've now more or less finished work on it. What I've done includes:

Making the role compatible with modern ansible versions
Refactored the scripts used to install tools and workflows
Simplifying the role somewhat (let the user supply their own restart galaxy handler)
Adding molecule tests
Adding linting

This makes the role pretty robust and usable now in my opinion. We are using it to deploy Galaxy servers in the cloud at Utrecht University. I'm wondering if you have any interest in us contributing back the changes to this repo, to ensure maintenance. (I would be willing to act as a co-maintainer for the repo if desired.)

dometto commented 1 month ago

Pinging @bernt-matthias

bernt-matthias commented 1 month ago

How can I help here?

dometto commented 1 month ago

This query in my comment above:

I'm wondering if you have any interest in us contributing back the changes to this repo, to ensure maintenance. (I would be willing to act as a co-maintainer for the repo if desired.)

No worries if not, but thought I'd ask!

bernt-matthias commented 1 month ago

In general the Galaxy community is happy for any contribution. I guess that additional potential reviewers could be found here: https://matrix.to/#/#galaxyproject_admins:gitter.im (also great for discussion).