galaxyproject / ansible-galaxy

An Ansible role for managing a Galaxy server
https://galaxy.ansible.com/galaxyproject/galaxy
58 stars 75 forks source link

Reports webapp with gunicorn #195

Open microfuge opened 1 year ago

microfuge commented 1 year ago

Hi,

Please let me know if I am wrong, but the "Galaxy reports" app will not run with uwsgi as now Galaxy uses Gunicorn. The templates still mentions uwsgi https://github.com/galaxyproject/ansible-galaxy/blob/main/templates/systemd/galaxy-reports.service.j2

And update to the role for this would be great. Or any advice on running the Reports app with gunicorn would also be very helpful.

Thanks!

adRn-s commented 1 year ago

I think {{ galaxy_venv_dir }}/bin/uwsgi is still a valid path to an executable, and it's in fact used in many places. Did you get an error message? It's easier to debug GH issues with factual information.

disclaimer: not a dev or maintainer, just a watcher on the repo.

hexylena commented 1 year ago

@adRn-s sure it's valid, but it's not used by Galaxy any more. Configuration for reports is now solely through gunicorn + gravity.

@microfuge we should definitely support this going forward, but I'm not sure when someone will update this issue. @natefoo has the most experience with gravity which is now a necessary part of galaxy configuration.

mvdbeek commented 1 year ago

@natefoo has the most experience with gravity which is now a necessary part of galaxy configuration.

No, you can use whatever you want, but it's certainly a lot easier to use gravity. I don't use gravity for development, that would be overkill.

hexylena commented 1 year ago

@mvdbeek if it were added to this role, we would want to use gravity, wouldn't want to special case reports.

mvdbeek commented 1 year ago

I do think that is exactly what you want to do. No need to litter gravity with special cases that have nothing to do with actually running Galaxy.