galaxyproject / ansible-postgresql

An Ansible role for managing a PostgreSQL server
https://galaxy.ansible.com/galaxyproject/postgresql
122 stars 58 forks source link

Backup options have issues with `-` #44

Closed hexylena closed 9 months ago

hexylena commented 1 year ago

I'm noticing my backups stopped a while back

root@bioinf-galaxy:/data/backups# cat /etc/cron.d/ansible_postgresql_backup
#Ansible: PostgreSQL Backup
0 1 * * * postgres '~postgres/backups'/bin/backup.py  --rsync-backup-opts -rptg --keep 30  --backup --clean-archive /data/backups

Here '~postgres..' isn't getting expanded, removing the ' fixes that, but the backup options also cause issues:

python3.8 ~postgres/backups/bin/backup.py  --keep 30  --backup --clean-archive /data/backups --rsync-backup-opts '-rptg'
usage: backup.py [-h] [--backup] [--keep KEEP] [--clean-archive] [--rsync-connect-opts RSYNC_CONNECT_OPTS] [--rsync-backup-opts RSYNC_BACKUP_OPTS] [--pg-bin-dir PG_BIN_DIR]
                 [-v]
                 backup_path
backup.py: error: argument --rsync-backup-opts: expected one argument