search

galaxyproject / blend4j

blend4j is a JVM partial reimplementation of the Python library bioblend for interacting with Galaxy, CloudMan, and BioCloudCentral.
Eclipse Public License 1.0
16 stars 22 forks source link

Create and show for dataset collections #13

Closed apetkau closed 10 years ago

apetkau commented 10 years ago

Hey John,

I've been working a bit on dataset collections and I managed to get HistoriesClient.showDatasetCollection() and HistoriesClient.createDatasetCollection() implemented. I based the structure of the code on how collections are implemented in bioblend http://bioblend.readthedocs.org/en/latest/api_docs/galaxy/all.html#module-bioblend.galaxy.histories. There's some examples in https://github.com/apetkau/blend4j/blob/feature/collections/src/test/java/com/github/jmchilton/blend4j/galaxy/Examples.java#L246 and integration tests in https://github.com/apetkau/blend4j/blob/feature/collections/src/test/java/com/github/jmchilton/blend4j/galaxy/HistoriesTest.java.

So far this is working for me, but I was interested in getting some feedback on whether or not this is how you were thinking of structuring the Dataset Collections API in blend4j.

Thanks,

Aaron

jmchilton commented 10 years ago

This is absolutely fantastic work, thanks a bunch!

@FreekDB made the good the point at the GCC hackathon that the beans package is a mess - too many classes and too many classes with similar names. I think the strategy you have outlined here of topic specific subpackages and differentiating request and response objects would be a great direction to take that whole library for a blend4j version 2.0.

apetkau commented 10 years ago

Awesome, thanks. My organization isn't perfect either (there are a few classes like Dataset that overlap multiple categories), but I'm glad it's useful.