galaxyproject / blend4j

blend4j is a JVM partial reimplementation of the Python library bioblend for interacting with Galaxy, CloudMan, and BioCloudCentral.
Eclipse Public License 1.0
16 stars 22 forks source link

Rework recent chagnes to be Java 6 compatible. #14

Closed jmchilton closed 10 years ago

jmchilton commented 10 years ago

Recent changes included use of java.util.Objects which is only available in Java 7+. To provide a Java 6+ alternative, bring in a few classes from Google Guava including Guava's Objects. Classes only and with a new package so we don't need to actually need clients to require the library as a dependency.

@apetkau do you mind if I make this change to fix the Java 6 compilation issues? https://travis-ci.org/jmchilton/blend4j/jobs/31005683

apetkau commented 10 years ago

Woops, completely forgot about Java 6. Thanks for looking into that. Yep, all the changes you've made make sense. Thanks.

apetkau commented 10 years ago

I think my tests may be making the testing stage take a bit longer now too, which is why it's still failing. I also remember that I commented out some tests that weren't working in 4079635f8b8a4e1587f89bace7b25bf464b0618c in case you were wondering about those.