search

galaxyproject / blend4php

A PHP API for interacting with Galaxy
http://galaxyproject.github.io/blend4php
GNU Lesser General Public License v3.0
6 stars 3 forks source link

User->create() argument checking #4

Closed spficklin closed 8 years ago

spficklin commented 8 years ago

Galaxy has specific rules for creating users. The name must be lowercase, etc. Should we add checks in the User>create() function to keep the user from providing bad argument values or do we get a good enough error from Galaxy to just return a FALSE and let the Galaxy error message inform the user?

cwytko commented 8 years ago

I'll see to that our function catches that and doesn't allow the user to invoke the api until the requirements are met that galaxy requires

spficklin commented 8 years ago

So after looking into it a bit it seems Galaxy is providing a proper error which can be retrevied by the user using the ->getError() function, so no need to add parameter checking.