Authenticate with GCE - Githubissues

galaxyproject / cloudlaunch-ui

A user interface for the cloudlaunch app

MIT License

8 stars 13 forks source link

Authenticate with GCE #12

Closed machristie closed 6 years ago

machristie commented 6 years ago

This fixes #6.

afgane commented 6 years ago

This looks very nice! It's too bad dome of the CloudBridge GCE functionality is still missing to test all of this.

A few times, I've run in the the case where I get UI issue like this: Anyone else seen it? Refreshing the page fixes it but it appeared more than once on the profile page as well as application page. Here's the output from the console:

Thanks for also fixing the cloud-based filtering when adding credentials.

machristie commented 6 years ago

That looks related to a change I made. I'm not getting that particular issue but I'll see if I can fix it.

machristie commented 6 years ago

@afgane I've committed a change that may fix the problem, but I'm not sure. The fix is to use cloud.name for the displayed name of the cloud when the cloud can't be changed. The cloud.text property is only set by ng2SelectAdjust for adding that property which is needed by ng2select.

afgane commented 6 years ago

Looks like we'll have to dig more. It seemed better as it didn't happen for a number of clicks but switching between a couple of clouds back and forth triggered it. It might just be the ng2select component too that's buggy because now the version dropdown locked up as well:

machristie commented 6 years ago

I've pushed a commit to the gce branch that should fix some of the problem that Enis mentions above. The fix is related to the cloud type filtering I added. There's still another issue with the UbuntuConfigComponent not implementing some methods that I'm still looking into.

machristie commented 6 years ago

Working on rebasing this branch with master and getting it up to date.

machristie commented 6 years ago

TODO:

[x] When editing existing credential, don't allow changing the cloud, in cloud-credentials-editor
[x] use the gce branch of cloudbridge to test saving GCE credentials
[x] rebase the branch to pull in latest changes on master
[x] show cloud label if not allowed to change? Is that still needed?
- no longer needed, already on master branch

machristie commented 6 years ago

Looks like there are conflicts again so I'll rebase again.

machristie commented 6 years ago

@afgane @nuwang I've finished rebasing and testing. This PR is ready to be reviewed now.