galaxyproject / cloudlaunch-ui

A user interface for the cloudlaunch app
MIT License
8 stars 13 forks source link

Add health check to My Appliances page #18

Closed machristie closed 6 years ago

machristie commented 6 years ago

Utilize the new health check task (added as part of the multi-task refactoring) to show a live status for all appliances for which CloudLaunch has the user's credentials.

UI Changes

Other considerations

afgane commented 6 years ago

split the current My Appliances list into two tabs, Current Instances and Launch History

Did we not agree on going with two separate pages vs. tabs, linked from the masthead dropdown menu?

machristie commented 6 years ago

@afgane I honestly couldn't remember but I had "two tabs" in my notes from the meeting. I'm fine with either way, with a slight preference for separate pages.

afgane commented 6 years ago

I'm leaning toward the two pages as well.

machristie commented 6 years ago

@afgane This change of the DeploymentTaskSerializer result from type DictField to type CharField is causing me an issue. The problem is that the serialized result value is a string, but it isn't proper JSON either. An example value of result in the serialized response is

"{'instance_status': 'terminated'}"

I tried to do a JSON.parse but it doesn't parse because it is using single quote instead of double quote.

Is it okay to change result back to a DictField? I think the only problem is when the database result value is not JSON but maybe we can deal with that by returning {"result": self._result} (or something to make it a dict) in that case?

afgane commented 6 years ago

Given the "{'instance_status': 'terminated'}" is just a return string, have you tried just flipping the quotes and seeing if it works?

I wanted to keep the DictField in the database, but was not able to because of the type issue described here: https://github.com/machristie/cloudlaunch/commit/089e2466f0fcbad3214d575d4e65ef8de589326a#diff-df9f9c31795954c14533b82f186d10f2R337