[WIP] GCE to GCP - Githubissues

galaxyproject / cloudlaunch-ui

A user interface for the cloudlaunch app

MIT License

8 stars 13 forks source link

[WIP] GCE to GCP #37

Closed almahmoud closed 4 years ago

almahmoud commented 5 years ago

Not fully tested yet. Goes with: https://github.com/galaxyproject/cloudlaunch/pull/167 https://github.com/CloudVE/djcloudbridge/pull/3 https://github.com/CloudVE/cloudbridge/commit/370487fc4e14be565d0e939f11b8d16b94e24571 https://github.com/CloudVE/cloudlaunch-cli/pull/14

nuwang commented 5 years ago

@almahmoud Instead of deleting the GCP related files, it would be better to rename them using git mv. Also, the deleted files have not been replaced with the renamed versions, so the tests are failing.

almahmoud commented 5 years ago

Sorry about that. Never deleted them, but used PyCharm's replace feature and forgot to manually add them afterwards as it excludes renamed files automatically...