search

galaxyproject / cloudman

Easily create and manage compute clusters on any Cloud.
https://galaxyproject.org/cloudman/
37 stars 23 forks source link

Helm v3 changes #105

Closed almahmoud closed 4 years ago

almahmoud commented 4 years ago

Migrations still need to be done, but I thought I'd PR code changes first for collective input

coveralls commented 4 years ago

Coverage Status

Coverage increased (+1.4%) to 90.292% when pulling f517524e72f2ba0e6aabcb4d2c28a9bb317a7e1e on helm_v3 into 7195774ffdfe340db2bb5c35b545ed558ea8f82d on master.

almahmoud commented 4 years ago

Tests finally passed. Let me know if I should change anything else

nuwang commented 4 years ago

After this change, I'm guessing we'll no longer be able to use the default namespace, because projman will raise an error if you try to create a project with an existing namespace. I think this is a good thing, because default is an implicit namespace, and we probably want to avoid exposing things that get installed to default for security reasons. @almahmoud @afgane Any thoughts on what the new default namespace could be called? "initial" or "starter" perhaps?

almahmoud commented 4 years ago

I don't mind changing the initial project, but I did special-case default to not throw an error even if namespace exists and not delete it (https://github.com/galaxyproject/cloudman/pull/105/files#diff-3d0ef3ae18103076ef9de75ea24376bdR105). Since kubectl will install into default namespace when no namespace is specified, I thought it would be good to have the project by default. I would even say let's make the project non-deletable as well potentially?

almahmoud commented 4 years ago

All changes now working, and made some more bug fixes as it was working with mock but not the real helm client (helm 3 does not list releases from other namespaces by default). Also packaged and working in the wild on am-dev, with both cloudman-boot and cloudman helm v3

almahmoud commented 4 years ago

I believe it's now ready to merged, along with CloudVE/cloudman-helm#12 and https://github.com/CloudVE/cloudman-boot/pull/10. Can be tested as am-dev Cloudman 2.0 appliance on CL.