search

galaxyproject / ephemeris

Library for managing Galaxy plugins - tools, index data, and workflows.
https://ephemeris.readthedocs.org/
Other
27 stars 38 forks source link

safeguard revisions #70

Closed bgruening closed 6 years ago

bgruening commented 6 years ago

revisions can be None ....

rhpvorderman commented 6 years ago 
revisions = repo_info.get('revisions', [])

Should never return None right? In that case it should return an empty list [] which has length zero.

Did you get an error message when running shed-tools install that indicates that something may be wrong in this assumption?

bgruening commented 6 years ago

Not in this case:

>>> repo_info = {'foo': None}
>>> revisions = repo_info.get('foo', [])
>>> print revisions
None
rhpvorderman commented 6 years ago

:+1: