galaxyproject / ephemeris

Library for managing Galaxy plugins - tools, index data, and workflows.
https://ephemeris.readthedocs.org/
Other
27 stars 38 forks source link

Option to test tools on update/install for Galaxy 18.05. #81

Closed jmchilton closed 6 years ago

jmchilton commented 6 years ago

Builds on #78 from @rhpvorderman since it modifies similar files.

While it does run the tests and produce a JSON output file that should be usable with planemo test_reports (http://planemo.readthedocs.io/en/latest/commands.html#test-reports-command) after the next Planemo release, marked as WIP because:

Also, what of these questions can we delay to a second iteration?

Implements https://github.com/galaxyproject/ephemeris/issues/76.

rhpvorderman commented 6 years ago

@jmchilton can you rebase on master? The commits from #78 are now in.

rhpvorderman commented 6 years ago

I am all for integrating the testing within the installation method. But this causes indeed the exit code problem. Doing two things at the same time creates ambiguity. However, you could argue that if a test fails, this means the tool should not be installed, which means installation has effectively failed. Also I am in favor of adding a shed-tools test subcommand, which can be regularly by cron, to check if all the installed tools still functions.

jmchilton commented 6 years ago

However, you could argue that if a test fails, this means the tool should not be installed, which means installation has effectively failed.

Yes - I think I agree. I'll see if I can make the exit code reflect the testing status.

Also I am in favor of adding a shed-tools test subcommand, which can be regularly by cron, to check if all the installed tools still functions.

Absolutely - this is an excellent idea - I'll try to reorganize this code to do that.