search

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes
MIT License
39 stars 36 forks source link

Can’t use metrics when the database uses `galaxyExistingSecret` #229

Open cyrilcros opened 3 years ago

cyrilcros commented 3 years ago

Hi, The new metrics deployment assumes you don’t use the galaxyExistingSecret way of storing the postgresql database password. It cannot find the database password in this case. Template line: https://github.com/galaxyproject/galaxy-helm/blob/328ce1720fd39bf1d9e7d76ebf5a804ed76c5acc/galaxy/templates/deployment-metrics.yaml#L52 Values: https://github.com/galaxyproject/galaxy-helm/blob/328ce1720fd39bf1d9e7d76ebf5a804ed76c5acc/galaxy/values.yaml#L181

Fix: use the _helpers.tpl generated value I think, which is galaxy.galaxyDbPassword https://github.com/galaxyproject/galaxy-helm/blob/328ce1720fd39bf1d9e7d76ebf5a804ed76c5acc/galaxy/templates/_helpers.tpl#L78

I am also not sure if the metrics deployment works if influxdb is not enabled (?).

nuwang commented 3 years ago

Thanks for catching that. The first issue needs a fix.

The metrics deployment won't work without influxdb, as the extracted data is dumped into influxdb. The source for the container is here: https://github.com/CloudVE/galaxy-docker-k8s-metrics