Replace container mapper rules with TPV

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes

MIT License

41 stars 38 forks source link

Replace container mapper rules with TPV #354

Closed nuwang closed 2 years ago

ksuderman commented 2 years ago

So does this eliminate the ability to set resource constraints (e.g. cpu and memory allocated to a tool) via the container_mapper_rules.yml file? Does TPV provide a similar mechanism? I use this feature extensively in abm.

afgane commented 2 years ago

It replaces it. It sill allows for local rules (https://github.com/galaxyproject/galaxy-helm/pull/354/files#diff-86e6e8118f9d5ad6d181dd2e12c268062e9a66f5ef98bd0cc44b93661d08e9b2R479) and also relies on global rules (https://github.com/galaxyproject/galaxy-helm/pull/354/files#diff-86e6e8118f9d5ad6d181dd2e12c268062e9a66f5ef98bd0cc44b93661d08e9b2R476) so not every installation needs to make these decisions repeatedly.