search

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes
MIT License
38 stars 36 forks source link

Set docker_enabled only once #413

Closed afgane closed 1 year ago

afgane commented 1 year ago

At the very least, having the enable_docker setting set twice in the default values file seems undesirable. On top of that, I don't think we run the chart with docker available much any more so disabling it by default seems like a reasonable option.

pcm32 commented 1 year ago

I'm not sure I'm getting this. With this jobs need to have a different way of resolving tool dependencies that is not through containers? Or this is something else?

afgane commented 1 year ago

You're right. I misunderstood what the enable_docker variable did so we do need it to set to true by default. But I still don't think we need it set twice in our values file.