search

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes
MIT License
38 stars 36 forks source link

Update s3-csi version to 0.35.2 #430

Closed nuwang closed 1 year ago

nuwang commented 1 year ago

xref: https://github.com/CloudVE/helm-charts/pull/4

yegortokmakov commented 1 year ago

FYI, for some reason this new version of the chart is not handling the empty strings in the values well, so I had to define csi-s3-secret manually outside of the csi-s3 chart. The error I was getting: 

error validating "": error validating data: [unknown object type "nil" in Secret.stringData.accessKeyID, unknown object type "nil" in Secret.stringData.secretAccessKey]

and should be fixed by defining default values in the chart itself.

yegortokmakov commented 1 year ago

also, right now the version of the driver is hardcoded and will have to be updated as well: https://github.com/galaxyproject/galaxy-helm/blob/master/galaxy/values.yaml#L316

but again, this was a breaking change in my case.

nuwang commented 1 year ago

New version of the chart is not handling the empty strings in the values well,

Which would means that default/empty IAM credentials won't work right? Sounds like a bug that needs to be fixed upstream. I guess the interim workaround is to hardcode something.

nuwang commented 1 year ago

Yeah, I just remembered that I made two upstream fixes that were never merged: https://github.com/yandex-cloud/k8s-csi-s3/pull/11 https://github.com/yandex-cloud/k8s-csi-s3/pull/20

Without the second one in particular, we had to manually package the chart and force the s3fs mounter. Last time I tried, the geesefs mounter had issues, in particular with caching: https://github.com/yandex-cloud/k8s-csi-s3/issues/18. Looks like we may have to do that again.

The lack of traction in getting these issues fixed was one reason we added support back for cvmfs.