search

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes
MIT License
41 stars 38 forks source link

CVMFS alien cache name mismatch #437

Closed ksuderman closed 1 month ago

ksuderman commented 1 year ago

We seem to have a bit of a mismatch in cvmfs cache name handling. The upstream chart uses cvmfs-alien-cache

And out chart uses {{ .Release.Name }}-cvmfs-alien-cache-pvc.

The mismatch causes the pvc name we create to mismatch the name expected by the daemonset. It would be better if we just used the nested chart's values, and if they are not defined, fallback to defaults.

nuwang commented 1 year ago

Makes sense. Even if multiple instances of the chart use the same alien cache, that should probably be ok. This is all such a mess because helm doesn't allow computed variables to be passed to included charts unless the included chart explicitly templates it. Badly breaks encapsulation.