search

galaxyproject / galaxy-helm

Minimal setup required to run Galaxy under Kubernetes
MIT License
38 stars 36 forks source link

Ensure that one of the dependent jobs succeeded. #453

Closed ksuderman closed 4 months ago

ksuderman commented 4 months ago

The tag-and-release job depends on the package-from-pr or package-from-manual jobs succeeding. However, the packaging jobs are mutually exclusive so we need to test if one, but not both, have succeeded.

See Stack Overflow

Closes #452

ksuderman commented 4 months ago

No, this will only tag the latest commit/version. I have a separate script I used to tag/release previous versions. That script didn't include --generate-notes since the commit messages have been vague and consist almost entirely of "Automatic Version Bumping from X to X+1". We can regenerate them if needed though.

I'll add my tag-and-release.sh script to the repo in a separate PR.

nuwang commented 4 months ago

So --generate-notes doesn't do the same thing as here? image

Is there someway we can make it add the changelog? That would be perfect.

ksuderman commented 4 months ago

No, it does not seem to when generated releases from past tags. See the 5.8.0 and 5.9.0 releases I just generated. Note that is just when generating release notes from previous tags/commits. It should be fine going forward.

nuwang commented 4 months ago

Should be good to go then?

ksuderman commented 4 months ago

I think so...