search

galaxyproject / galaxy-tours

Collection of Galaxy-tours
MIT License
6 stars 3 forks source link

adopt to latest Galaxy changes #6

Closed bgruening closed 8 years ago

bgruening commented 8 years ago

Similar to https://github.com/galaxyproject/galaxy/pull/2715/

How do we handle these kind of changes, if we merge this PR it will only work with dev. ping @guerler @dannon

dannon commented 8 years ago

@bgruening The thing I have to do first is to write a set of best practices for tour writing and using selectors.

We probably realize now that "textarea#text-content" was never a good selector, right? This should have been much more precise, using an absolute identifier and digging down to the element in question from there.

dannon commented 8 years ago

I forgot the most important part of my reply. It doesn't fix the problem that we changed the structure of that box significantly, and my plan is to build this backwards compatibility into the actual tour loading -- there is already manipulation of the tours and selectors on load, and maintaining compatibility there via manipulation of the selectors at load time would be locked to the version of the Galaxy server in question, and should work well without requiring any additional markup.

bgruening commented 8 years ago

I'm completely on your side here. Just wanted to get this PR out and start a discussion on how to track these kind of changes and when we need to merge them.

Thanks @dannon!