search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.38k stars 996 forks source link

Component property mutation #11636

Open dannon opened 3 years ago

dannon commented 3 years ago

This can (and has) caused hard to detect bugs and should be avoided. Many of these were fixed in xref https://github.com/galaxyproject/galaxy/pull/11121, which adds updated eslint tooling to catch them early, but some remain. This list is here to track fixing of them.

https://eslint.vuejs.org/rules/no-mutating-props.html https://vuejs.org/v2/guide/migration.html#Prop-Mutation-deprecated

Components that still currently mutate props:

mvdbeek commented 2 years ago

I'll push this one, but maybe we could also de-milestone it and put it in a project ?

mvdbeek commented 2 years ago

@dannon can you put this on a UI/UX project ?