improve UX of WF node labels

martenson commented 8 years ago

the labels were implemented in https://github.com/galaxyproject/galaxy/pull/1251

we probably need:

[x] better presentation of validation of 'uniqueness' that won't use Toastr (should be only for async notifications) and just show inline renaming error
[x] UI for hinting that the label is 'clickable' (possibly the same that is used for History name (dotted border)
[x] Replace step names with labels when loading workflow and keep insync in the editor.
[x] James reported landing in a state with duplicated labels on IRC. Proved to be non-trivial to reproduce.
[x] Allow labeling tool nodes in the editor. (Other nodes use the same View for the editor but tools reuse a view from the tool form).

ping @jxtx

hexylena commented 8 years ago

@martenson milestone update?

martenson commented 8 years ago

we need a future milestone :)

martenson commented 8 years ago

cleared

jmchilton commented 7 years ago

Ping @guerler - in response to your IRC question. It would be really nice to unify name and labels to just be labels (since labels are uniform across workflow input types) - it is just a matter of doing it in a backward compatible way I guess.

guerler commented 7 years ago

Sounds good.

guerler commented 7 years ago

Fixed with a set of PRs, ending with #3644

galaxyproject / galaxy

improve UX of WF node labels #1264