search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.38k stars 992 forks source link

Enhancement UI/UX: Have all links that open a GIE start that in a new tab, leaving original Galaxy tab open #12848

Open jennaj opened 2 years ago

jennaj commented 2 years ago

Describe the bug Jupyter and Rstudio launch in two different ways from the Galaxy app. One is nicer for the user.

Galaxy Version and/or server at which you observed the bug Galaxy Version: 21.09 but not new (was this way in 21.05) Commit: N/A

To Reproduce Steps to reproduce the behavior:

  1. Start up an interactive tool
  2. When opened right after starting, from the link stating “ready” == the IE replaces Galaxy in that same browser window/tab.
  3. "User > Active IEs" == click on the listing and it opens a new tab. The Galaxy tab is still open. This is better/expected.
  4. To "quit" out of the IE -- clicking on the button within the IE doesn't appear to be doing anything, and the user has to close that tab/window, then log back into Galaxy (if the Galaxy tab was replaced) and delete the IE dataset in the history (will appear to stay in "executing" mode) even if the IE is deleted under "User > Active IEs" as a persistent artifact.
  5. Users are most likely to use the tool right after launching via the "ready" link, especially when someone is new to it.
  6. Not great for figuring out dataset numbers for the gx_get() or making sure stuff is actually saved back with gx_save() or what dataset number ended up being assigned via a gx_put().
  7. If a user starts up two IEs, only the first will actually launch due to a quota of one active IE per account. This isn't clear in the UI.

Expected behavior

  1. Always open IEs in a new tab, from either launch point.
  2. If an IE is removed from "User > Active IEs", the dataset related to it should not display in the history as executing (yellow) anymore. Maybe just a "green" artifact dataset? Or delete/purge it? The session is already technically purged and non-recoverable.
  3. Add in a warning on the "User > Active IEs" to note the number of active IEs permitted on the server for that user. "IE quota"? Configurable by admins and displayed in the UI where users can find it?

Screenshots

Screen Shot 2021-11-03 at 5 19 08 PM

Additional context

cc @hexylena @dannon @natefoo -- please help with triage and tags -- not sure exactly what this touches

natefoo commented 2 years ago

GxITs opening in the Galaxy tab is mentioned in the big GxIT issues thread (#8899). This may be implemented in the new history, I'm not sure.

I added functionality for stopping (without deleting) GxITs in #10497 (and @mvdbeek discussed some potential improvements to this in the Backend WG a few days ago) but this is only exposed via the Active InteractiveTools page and the new history. With the Jupyter GxIT you can also stop it from within Jupyter by using the Shut Down option in the menu. As far as I know, RStudio does not have this option.

hexylena commented 2 years ago

I hope so, we really need them to open in the main panel. Can't wait for the new history! (And yeah, not to my knowledge can you 'shut down' rstudio.)