search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

[22.01] make gravity respect `$GALAXY_PID` #14351

Open bernt-matthias opened 2 years ago

bernt-matthias commented 2 years ago

Describe the bug

With the upgrade to 22.01 it seems that Galaxy does not write a pid file as before. I start Galaxy as follows:

export GALAXY_PID="/run/galaxy/galaxy-dev.pid"
...
cd $GALAXY_ROOT && sh run.sh start --daemon

Answer from @natefoo on gitter

So Gravity does not respect $GALAXY_PID, the pidfile location (for the supervisord pid) is hardcoded to $GRAVITY_STATE_DIR/supervisor/supervisord.pid.

Galaxy Version and/or server at which you observed the bug

22.01

To Reproduce

See above.

Expected behavior

pid file is written

natefoo commented 2 years ago

WIP so I don't lose it by the time I get back from GCC:

https://github.com/galaxyproject/gravity/commit/2e1df4bf19cea951ff7de350f5895a572d585f3a but you have to export it from Galaxy's commmon_startup_functions.sh and even then supervisord seems not to be daemonizing... anyway, have to go check out a demo, I will return to it.