galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.38k stars 998 forks source link

\mathplus not formatted by doi citation #14700

Open patrick-austin opened 2 years ago

patrick-austin commented 2 years ago

Describe the bug Citing a DOI using a + symbol in the title appears in Galaxy as \mathplus:

DOI as it appears in Galaxy: image

When following the link to the article, the title appears as: image

Galaxy Version and/or server at which you observed the bug Galaxy Version: 22.01 Commit: cba4677bb40652a1ae846d3586af01e4c34bc0ed

To Reproduce Include the citation: <citation type="doi">10.1063/1.5143190</citation>

Expected behavior Expected the \mathplus symbol to rendered as +

Screenshots See above.

dannon commented 2 years ago

Did a quick dig into this and it looks like the issue is in the renderer we use not supporting latex math extensions. I don't know why it's a \mathplus in the doi instead of just a +, which doesn't need encoding.

Raw response from doi.org for this DOI:

@article{Hourahine_2020,
        doi = {10.1063/1.5143190},
        url = {https://doi.org/10.1063%2F1.5143190},
        year = 2020,
        month = {mar},
        publisher = {{AIP} Publishing},
        volume = {152},
        number = {12},
        pages = {124101},
        author = {B. Hourahine and B. Aradi and V. Blum and F. Bonaf{\'{e}} and A. Buccheri and C. Camacho and C. Cevallos and M. Y. Deshaye and T. Dumitric{\u{a}} and A. Dominguez and S. Ehlert and M. Elstner and T. van der Heide and J. Hermann and S. Irle and J. J. Kranz and C. Köhler and T. Kowalczyk and T. Kuba{\v{r}} and I. S. Lee and V. Lutsker and R. J. Maurer and S. K. Min and I. Mitchell and C. Negre and T. A. Niehaus and A. M. N. Niklasson and A. J. Page and A. Pecchia and G. Penazzi and M. P. Persson and J. {\v{R}}ez{\'{a}}{\v{c}} and C. G. S{\'{a}}nchez and M. Sternberg and M. Stöhr and F. Stuckenberg and A. Tkatchenko and V. W.-z. Yu and T. Frauenheim},
        title = {{DFTB}$\mathplus$, a software package for efficient approximate density functional theory based atomistic simulations},
        journal = {The Journal of Chemical Physics}
}

And, trying this on citation.js.org/demo/ you get:

Hourahine, B., Aradi, B., Blum, V., Bonafé, F., Buccheri, A., Camacho, C., Cevallos, C., Deshaye, M. Y., Dumitrică, T., Dominguez, A., Ehlert, S., Elstner, M., van der Heide, T., Hermann, J., Irle, S., Kranz, J. J., Köhler, C., Kowalczyk, T., Kubař, T., … Frauenheim, T. (2020). DFTB\mathplus, a software package for efficient approximate density functional theory based atomistic simulations. The Journal of Chemical Physics, 152(12), 124101. https://doi.org/10.1063/1.5143190

(with the unconverted \mathplus).

Following the 'how to cite' on the article itself, the citation download from https://aip.scitation.org/action/showCitFormats?doi=10.1063/1.5143190&type=show in bibtex is the following, with all the latex converted already. I don't see a good way to request this from doi.org.

@article{doi:10.1063/1.5143190,
author = {Hourahine,B.  and Aradi,B.  and Blum,V.  and Bonafé,F.  and Buccheri,A.  and Camacho,C.  and Cevallos,C.  and Deshaye,M. Y.  and Dumitrică,T.  and Dominguez,A.  and Ehlert,S.  and Elstner,M.  and van der Heide,T.  and Hermann,J.  and Irle,S.  and Kranz,J. J.  and Köhler,C.  and Kowalczyk,T.  and Kubař,T.  and Lee,I. S.  and Lutsker,V.  and Maurer,R. J.  and Min,S. K.  and Mitchell,I.  and Negre,C.  and Niehaus,T. A.  and Niklasson,A. M. N.  and Page,A. J.  and Pecchia,A.  and Penazzi,G.  and Persson,M. P.  and Řezáč,J.  and Sánchez,C. G.  and Sternberg,M.  and Stöhr,M.  and Stuckenberg,F.  and Tkatchenko,A.  and Yu,V. W.-z.  and Frauenheim,T. },
title = {DFTB+, a software package for efficient approximate density functional theory based atomistic simulations},
journal = {The Journal of Chemical Physics},
volume = {152},
number = {12},
pages = {124101},
year = {2020},
doi = {10.1063/1.5143190},

URL = { 
        https://doi.org/10.1063/1.5143190

},
eprint = { 
        https://doi.org/10.1063/1.5143190

}

}

I'm going to make sure we're using https://github.com/citation-js/citation-js/tree/main/packages/plugin-bibtex correctly, but in the event we already are and this is a shortcoming (given the demo doesn't work on citation.js.org either) as for a suggestion for a fix, maybe we just add a few manual replacements for common-ish latex-isms that aren't covered in citation-js?

elichad commented 2 years ago

Also noticed another misrendering, this time where there is italicisation in the original paper title that's been pulled through with <i> tags:

-  Liborio, L., Sturniolo, S., & Jochym, D. (2018). 
  Computational prediction of muon stopping sites using 
  \lessi\greaterab initio\less/i\greater random structure 
  searching (AIRSS). The Journal of Chemical Physics, 
  148(13), 134114. https://doi.org/10.1063/1.5024450 

Paper: https://doi.org/10.1063/1.5024450

bernt-matthias commented 1 year ago

Just found another one

 Kent, W. J. (2002). \lesstt\greaterBLAT\less/tt\greater—The \lesstt\greaterBLAST\less/tt\greater-Like Alignment Tool. Genome Research, 12(4), 656–664. 

https://doi.org/10.1101/gr.229202