search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

Export citations exports citations also for deleted datasets #15437

Open bernt-matthias opened 1 year ago

bernt-matthias commented 1 year ago

Describe the bug

If I export citations from a history I also get citations from deleted datasets. I noticed this for the tool Split file to dataset collection. See this history https://usegalaxy.eu/u/maze/h/unnamed-history-4

Galaxy Version and/or server at which you observed the bug Galaxy Version: usegalaxy.eu so I guess 22.05 Commit: don't know

To Reproduce

Export citations for history linked above

Expected behavior

Only non-hidden and non-deleted datasets are used to get citations.

ahmedhamidawan commented 1 year ago

Notes:

bernt-matthias commented 1 year ago

Even if I do not see a use for exporting citations of deleted datasets, I like the idea to give the user more control (downside is that more clicks are necessary).. Could also help with https://github.com/galaxyproject/galaxy/issues/15438

bernt-matthias commented 1 year ago

Hmm.. Deleted datasets might still have been used to create active datasets.