galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.34k stars 978 forks source link

tool entry point is polled also for anonymous/sessionless users #15555

Open mvdbeek opened 1 year ago

mvdbeek commented 1 year ago
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: Traceback (most recent call last):
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: File "/cvmfs/main.galaxyproject.org/galaxy/lib/galaxy/web/framework/decorators.py", line 337, in decorator
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: rval = func(self, trans, *args, **kwargs)
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: File "/cvmfs/main.galaxyproject.org/galaxy/lib/galaxy/webapps/galaxy/api/tool_entry_points.py", line 59, in index
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: entry_points = self.interactivetool_manager.get_nonterminal_for_user_by_trans(trans)
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: File "/cvmfs/main.galaxyproject.org/galaxy/lib/galaxy/managers/interactivetool.py", line 218, in get_nonterminal_for_user_by_trans
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: trans.app.model.Job.session_id == trans.get_galaxy_session().id
Feb 10 09:31:53 galaxy-web-06.tacc.utexas.edu galaxyctl[86581]: AttributeError: 'NoneType' object has no attribute 'id'
martenson commented 1 year ago

Anonymous users can run ITs so polling for them is expected and in my testing works well. #15659 will address the case where there is both no user and no galaxy session.

However we shouldn't poll if the instance has ITs disabled...