search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.38k stars 999 forks source link

History item incorrect state when collection created from running outputs #15591

Open neoformit opened 1 year ago

neoformit commented 1 year ago

Describe the bug I created a list collection from a set of running (orange) history items. The collection appears as completed (green) when the items are still running. When I open the collection, the items are displayed with the correct state. When I return to the history the collection still has the incorrect (green) state.

Galaxy Version and/or server at which you observed the bug Galaxy Version: 22.05 (Galaxy AU)

To Reproduce Steps to reproduce the behaviour:

  1. Run a tool with multiple outputs
  2. Create a collection from outputs while still running
  3. Observe that the collection status is "completed"

Expected behaviour I guess that the state of a collection is ambiguous since you can create a collection from datasets of mixed state. I would expect the collection state to be set to the "lowest" internal state (where failed is lowest and completed is highest).

mvdbeek commented 1 year ago

Collections don't have a state, the have jobs going into the job state summary. I suppose we could reconstruct the job state summary form component jobs, but that's probably hard.

neoformit commented 1 year ago

I think it's worth looking in to, it results in a pretty weird UX. If I have multiple collections (from different jobs) the only way to see when one has completed is to keep opening and check them one-by-one.