search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.35k stars 979 forks source link

Tours don't show immediately and run way too fast #15634

Open mvdbeek opened 1 year ago

mvdbeek commented 1 year ago

The startup delay (15 seconds approx ?) is so long I thought it was broken

tour

If you click on play it just goes way too fast ... can we just disable play ? I think clicking on continue makes much more sense

guerler commented 1 year ago

I think we should fix that, but keep the auto-play option.

mvdbeek commented 1 year ago

What's the point of the auto-play ? I don't think you can find a speed that fits everyone, and it also doesn't seem like you can stop it ?

dannon commented 1 year ago

I think being able to watch a tour on rails without clicking next, next, next has value; we can just make it slower. Something with a comfortable time to be able to read the contents of the box. We originally wanted 3 modes for tours:

1) tour is descriptive only, does no click actions, and the user clicks on things in the interface as appropriate with the tour advancing as it should. 2) Click next, next, next to step through with the tour manager performing click actions on each step as appropriate driving application state 3) Totally on rails, sit back and watch an analysis happen.

mvdbeek commented 1 year ago

I mean, I keep clicking on them accidentally and then I hate galaxy and want to throw my computer out of the window. If we have a story where it makes sense we can enable them ? Or at least we can stop the auto tour ?

dannon commented 1 year ago

Hah. Yeah, the auto tour should pause on any interaction from the user at all (even interaction with Galaxy and not the tour directly -- you can probably safely assume if the user is clicking on things, stop, and when the user is ready to proceed they can continue)

mvdbeek commented 1 year ago

The startup delay (15 seconds approx ?) is so long I thought it was broken

It's https://github.com/galaxyproject/galaxy/blob/f20b5389fb25c83230def253403c51d290288f4b/client/src/components/Tour/Tour.vue#L3 that causes the delay, we're reloading all user histories and waiting for it. The quick hack is just to wait for currentHistory. That provider needs to go though, it's crazy to fetch all user histories there.

itisAliRH commented 1 year ago

The startup delay (15 seconds approx ?) is so long I thought it was broken

It's

https://github.com/galaxyproject/galaxy/blob/f20b5389fb25c83230def253403c51d290288f4b/client/src/components/Tour/Tour.vue#L3

that causes the delay, we're reloading all user histories and waiting for it. The quick hack is just to wait for currentHistory. That provider needs to go though, it's crazy to fetch all user histories there.

@mvdbeek The history and user stores will be migrated to pinia and also the CurrentUser and UserHistories providers will be removed in #15108.