search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

help and encourage possible reviewers #1569

Open martenson opened 8 years ago

martenson commented 8 years ago

Lately we have so many PRs and so much activity on the Galaxy repo that even the full time developers have difficulties to catch up on them while doing so provides bigger and bigger overhead.

This is a good problem to have.

I had a look around and found a bot/idea that might help us a little with this by mentioning reviewers based on git blame of the changed lines. https://github.com/facebook/mention-bot

There might be other ideas how to help this and this seemed like a good start.

Reviews should not turn into a burden and being mentioned by a bot should not impose any pressure. Just a hint.

hexylena commented 8 years ago

https://github.com/kentcdodds/issue-template might also be useful, especially for reporting broken tools on main, etc? idk. Just saw it in a blog post recently and it looked neat.

ghost commented 8 years ago

Just an observation:

This is a limitation of the github ecosystem, and it's insistence of a shared change being synonymous with a pull request. Pull requests are a barrier to review by many eyes, as only 'project owners' get notified. Larger FOSS projects generally use mailing lists to share patches (which git supports very efficiently with tools such as 'git am' and 'git format patch'), which is a far more scalable and easily accessible way of reviewing changes.

nsoranzo commented 8 years ago

@einon: If you click the "Watch" button on the GitHub repository, you should receive notifications for all pull requests and issues.

ghost commented 8 years ago

@nsoranzo That's a very clunky interface, and again not very scalable - there's no way I can get through a few hundred patchsets a day (comfortably possible with mailing lists) if every time I have to click through to a website to view each one. The issue is exacerbated even more if I need to apply patches to a local git tree to test. There's a reason why most of the large projects (that I'm familiar with) only use github for distribution, not active development.

nsoranzo commented 8 years ago

@einon You can receive notifications by email.

ghost commented 8 years ago

@nsoranzo https://github.com/galaxyproject/galaxy/pull/1658#issuecomment-179299519 - Thanks, but I rest my case...

martenson commented 8 years ago

Your case is received @einon and your input is valued.

natefoo commented 8 years ago

The whitespace/PEP-8 commits might make that blamelist somewhat inaccurate.

hexylena commented 5 years ago

Github has implemented features for this to suggest potential reviewers. Is that sufficient or do we need something more?