galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.42k stars 1.01k forks source link

BAM datasets preview provides only header #15940

Open wm75 opened 1 year ago

wm75 commented 1 year ago

Describe the bug When clicking the eye icon of a BAM dataset, only the SAM header gets displayed instead of the SAM view of header and body as used to be the case previously.

This will likely become an issue during introductory trainings (e.g. during smorgasbord) when trying to explain SAM/BAM format.

Galaxy Version and/or server at which you observed the bug usegalaxy.org and usegalaxy.eu

To Reproduce Steps to reproduce the behavior:

  1. Click on the eye icon of any bam dataset
  2. Only the BAM's header gets displayed

Expected behavior header and body get displayed

bernt-matthias commented 1 year ago

I verified this partially. But it might this be a problem of BAM files where the header fits on a screen? I tested one with a larger header:

For small BAM files:

the header is shown. There is no scroll bar .. and therefore (maybe) we cant scroll and the rest is not loaded?

In case someone wants to play around: https://usegalaxy.eu/u/maze/h/bam-test

mvdbeek commented 1 year ago

I suspect this might be regression with the new tabular display component.

bernt-matthias commented 1 year ago

Same (small header dataset) is shown completely on my 22.05 instance.

bernt-matthias commented 1 year ago

On initial display there is: https://usegalaxy.eu/datasets/4838ba20a6d86765a894fb8e6a07d459/display/?preview=True On the after scrolling down: https://usegalaxy.eu/dataset/display?dataset_id=4838ba20a6d86765a894fb8e6a07d459&offset=1326317698

The 2nd does not happen when the small-header-bam is viewed. When scrolling a scrollbar is shown, but nothing happens.

That's it from my side .. was just curious .. and wanted to practice the network tab of the browser dev tools (which @mvdbeek pointed me to) a bit more.

dannon commented 1 year ago

Thanks for the good example reproducing this -- I'll take a look!