search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.37k stars 991 forks source link

Bug: Copy and Unshare functions on Histories Shared with Me #17204

Open jennaj opened 9 months ago

jennaj commented 9 months ago

Describe the bug

  1. Copy function on User > Histories Shared with Me doesn't do anything (UI "blinks" once quickly, but history not copied into account)
  2. Unshare function on same view results in a "grid refresh" error and when UI reloaded, not removed from listing
  3. View works fine

Galaxy Version and/or server at which you observed the bug Galaxy Version: ({"version_major":"23.2","version_minor":"rc1"}

To Reproduce Steps to reproduce the behavior:

  1. From account1, share a history with account2 by email address using History > Share or Publish > Share History with Individual Users
  2. In account2, attempt to Copy that history, or Unshareit.

I can share a history with whoever works on this if they need more context.

jennaj commented 6 months ago

Hi @dannon This function is still not working in the pre-release loaded onto ORG. This is a release blocker imo. Sharing functions should work, and more people will notice since the "shared with me" view is more visible on the default Data > Histories view now. If you want an example, we can build one up with two testing accounts.

The Galaxy Server is running version 24.0.rc1 , and the web client was built on Thursday Mar 7th 8:24:35 2024 GMT-8 .

jennaj commented 6 months ago

This seems fixed now! I had to refresh the both the "from" and "to" accounts. That's probably Ok.

details I noticed:

  1. view works great
  2. import works great
  3. unshare -- I'm really missing this. The "to" person cannot unshare. This leaves the listing cluttered. Function no longer supported?
  4. Data > Histories > Histories shared with me -- the order of the listing seems to be when the the history was last updated (by the other person). This used to be when the history was shared, which made it a bit easier to find a newly shared history. And ... because the "to" person cannot unshare (importing does not remove it from the listing) this again adds to the clutter.

  5. Being able to select where to store the data before importing -- short vs long term -- is really nice (works for all imports but first noticed it here).

    Adding back "unshare" would probably be enough. Am I missing how to do this? Was it dropped on purpose?

Pre-24.0 menu: Screen Shot 2024-03-12 at 1 54 41 PM

24.0 new menu: (view leading to import makes sense) Screen Shot 2024-03-12 at 1 55 37 PM

Extra -- this list view would probably benefit from checkboxes and buttons at the top/bottom for batch actions. Tricky since import/view are both one-history-at-a-time, but unshare was nice as a batch. We can think about this. Per-history unshare in the pull-down menu is what I think we need now.

jdavcs commented 6 months ago

Label updates: I've replaced bug with enhancement - it seems this is no longer a bug (and not a release blocker). Please reassign if this is incorrect.