galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.34k stars 978 forks source link

History grid follow-up #17283

Open bgruening opened 5 months ago

bgruening commented 5 months ago

In https://github.com/galaxyproject/galaxy/pull/17219 @guerler migrated the grid to vuejs. This issue is a follow-up with items that we have found during the review but are not strictly due to the PR but long-standing problems.

grafik

grafik

ElectronicBlueberry commented 5 months ago

the advanced search is also not aligned to other pages, e.g. tools, where it is part of the side-panel

We need to think about how these advanced searches interact with the activity bar. Do we still want to keep them in the side-panel, when the activity bar is a default feature? If so, when do they appear, how can a user navigate back to them, and where do they appear?

I think I'd prefer having them in the center panel, though in a different layout then currently depicted in the screenshot. Maybe next to the list, or more horizontal. Imo adding them to the sidebar will make the activity bar a bit more confusing to navigate, as it ties the center panel content and the side-bar content together, which is a behavior were trying to reduce in #17284

Though I'm a bit on the fence on this, and would like to hear different suggestions for solutions.

ahmedhamidawan commented 5 months ago

I think I'd prefer having them in the center panel

I agree, advanced searches that show an extensive list of results in the center panel, should live in the center panel (like in the recently vueified grids; like the upcoming new WorkflowList view or the pages/histories... views). The only case for having an advanced search in a panel is if there is a list of items below the search that is filterable; like in the HistoryPanel where the filters actually apply to the items below the search.

In the case of the Tool search, since the filters from the advanced menu do not apply to the tools below the search, the panel should not have an advanced search, and instead the FilterMenu component should be moved to the center panel ToolsList (like in all the grids). There then has to be a button that points to the ToolsList in the ToolPanel though, which needs to be prominent.