galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

Wrong permissions on output html_files when returning from pulsar to galaxy #17826

Open martindemko opened 7 months ago

martindemko commented 7 months ago

Hi there, I don't know if this is a bug, but I had to change one line of code to overcome this. Our architecture is Galaxy (72070dbd0a6d0f418d0b8f914825ea2b8e6a0a88) runinng on Debian 11 comunicating with Pulsar (v 0.15.3) via RabbitMQ (docker image rabbitmq:3.11-management). Whenever I run a tool using html_files for an output, the output dataset itsself is fine (644) as well as html_files directory (755) but all the data inside have unpleasant permissions (600). The real issue is when trying to show the data in Galaxy, when Nginx user (www-data) doesn't have access to see the data. Adding Nginx user to Galaxy user group doesn't help, cause the relevant data are not readable for group at all. I tried to use every mask I have found in the documentation and my Galaxy user umask is 0022. Funny thing is, that when using nginx upload module the nginx user is the one to move the data with perm 444, so everything works. However, I don't think it's the answer, cause I already talked about his with few people and nobody gave me a simple answer like this: just use nginx upload module. I have found this accidently when comparing two Gaalxy servers (one using upload module and the other one not). Thank you for your time (anybody), Martin

martenson commented 7 months ago

xref https://github.com/galaxyproject/galaxy/pull/16541

mvdbeek commented 7 months ago

I'm not following why you linked https://github.com/galaxyproject/galaxy/pull/16541 @martenson