search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

Required Parameter Highlighting Disappears on Galaxy Tool Form #18323

Open tcollins2011 opened 5 months ago

tcollins2011 commented 5 months ago

Describe the bug

Upon loading a Galaxy tool form, any required parameters that are not set are highlighted in a blue box. If one of these parameters is part of a conditional section in the form and the user switches between different conditional options, the highlighting for that parameter disappears.

Galaxy Version and/or server at which you observed the bug Galaxy version 24.0.3.dev0 Commit: 3a42234d3ede55253e8806caa8be03ebf8c9b45c

Browser and Operating System Operating System: Windows, Browser: Chrome

To Reproduce Steps to reproduce the behavior:

  1. Go to the tool Freyja: Aggregate and visualize on UseGalaxy.org
  2. Change provide metadata sample to no
  3. Change provide metadata sample to yes
  4. See that the highlighting does not return

Expected behavior The highlighting should return if the required parameter is unset.

Screenshots Galaxy (5)

mvdbeek commented 5 months ago

The video quality is pretty bad so maybe I've missed it, but as far as I can tell the highlighted parameter is Provide time(s) metadata file, which is highlighted as soon as provide metadata sample is set to Yes. I'm not seeing anything wrong in your screencapture or when I try it.

tcollins2011 commented 5 months ago

I'll try and upload a better video, but I think the problem is that on page load Provide time(s) metadata file under a conditional defaulted to yes on page load. This causes it to be highlighted in the blue box. However if a user sets the Provide a sample metadata file for plotting data over time? to no and then back to yes the blue highlighting is gone, even though the Provide time(s) metadata file is still required.