galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.37k stars 992 forks source link

Relaunch all failed jobs at once, for a given step #18442

Open vladvisan opened 2 months ago

vladvisan commented 2 months ago

image Screenshot taken from @ahmedhamidawan's GCC presentation since my instance doesn’t have this feature yet.

Related to

Description

Adjacent ideas

Labels

mvdbeek commented 2 months ago

I would say the most common thing to do is to re-run a single job, this is the default behavior now, and I think that should remain that way.

If not, if there are for example 50 failed jobs, it can be very tedious.

you can select the input collection today and all jobs will re-run. There should probably be a way to switch between those two modes more easily, so you don't need to find the input collection. The information on whether or not the job was part of a mapped over collection is available to the frontend.

Handle the cases where there is a mix of successful jobs, failed jobs, running jobs, waiting-to-be-run jobs, ..

You can rerun the whole collection and enable the job cache, that would the equivalent action

One talk at GCC mentioned a « multi-select datasets » option when launching a tool, maybe the logic or page could be re-used/pre-populated ?

this is an entirely different thing that will result in a different output structure that is flattened by one level

The rest sounds good and we should do it IMO, thanks for writing up the issue.

vladvisan commented 2 months ago

Thanks for the feedback.

I would say the most common thing to do is to re-run a single job, this is the default behavior now, and I think that should remain that way. Good point.

you can select the input collection today and all jobs will re-run

You can rerun the whole collection and enable the job cache, that would the equivalent action Good point, thanks, I haven't enabled it on my instance yet, I want to test this out soon.

this is an entirely different thing that will result in a different output structure that is flattened by one level I understand.

vladvisan commented 2 months ago

Also a separate comment:

"Resume dependencies from this job" even for re-runs of succesful jobs?

mvdbeek commented 2 months ago
  • individual datasets

yes, that's right, if you click on rerun there you can replace the single input with the higher level input (i.e. the collection input). I agree that this should probably a more direct option in the user interface, but I wanted to point out that you can do this.

vladvisan commented 2 months ago

UI option Ah, I see, I was able to select the collection as you indicated, in the re-run screen:

Basic results

Advanced results (resume dependencies) When I select the “Resume dependencies from this job?” option, the execution refuses to launch, with the following error screen/message (I crossed out the irrelevant information): image

I tested this (on Galaxy version 23.2.2.dev0):

Both cases led to the above error message.