Changing current history with a populated uploader prevents users from beginning upload

galaxyproject / galaxy

Data intensive science for everyone.

https://galaxyproject.org

Other

1.37k stars 992 forks source link

Changing current history with a populated uploader prevents users from beginning upload #18662

Open ahmedhamidawan opened 1 month ago

ahmedhamidawan commented 1 month ago

Galaxy Version and/or server at which you observed the bug Galaxy Version: 24.1.2.dev0 (usegalaxy.org)

To Reproduce Steps to reproduce the behavior:

Open the Uploader
Add a file to upload (local file or paste)
Do not start upload yet, and exit the modal
Change your current history
Open Uploader again
Click Start but nothing happens

Expected behavior Clicking Start should start the upload into this changed current history

Screencast

https://github.com/user-attachments/assets/2bac4031-8625-4c3f-92b0-ed6eebbecd7c

davelopez commented 1 month ago

Just to make sure I got this right. If we have files in the upload that have not yet been sent to the current history and we change the current history:

Option 1: the upload queue stops and the remaining files to be uploaded will now target the "new" current history.
Option 2: we reset the current upload queue and start fresh for the new current history.
Option 3: something else I didn't get...

What option did we decide on for the fix?

mvdbeek commented 1 month ago

Uploads that are defined at the time of clicking the start button go to the current history.

davelopez commented 1 month ago

Got it now thanks! :+1: