search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.38k stars 996 forks source link

Multiple inputs do not work across subworkflows #1889

Open bgruening opened 8 years ago

bgruening commented 8 years ago

The right workflow shows a concat tool that can take n input files. If I use this workflow as a subworkflow (the left image) I can not insert multiple input files. The output from get_pos_data is not able to connect to selex_dataset_postprocessing.

This would work if I define n inputs in the workflow on the right, but usually n is not known in advance and you would like to include as many inputs as needed - also in a subworkflow.

multiple_inputs_subworkflows

xref: https://github.com/galaxyproject/galaxy/issues/1387 ping @jmchilton @guerler

jmchilton commented 8 years ago

One can imagine solving this by introducing a multi-input module (or a flag on the input module) or by introducing module to build a list from inputs and switching the input on the right to a collection input. The problem with the former is that it would be very unclear to users when to use muliti-inputs versus collection inputs. The problem with the latter is that collection is unnatural and seemingly superfluous. I guess I prefer the second problem - it is closer to what we have now (less to implement) and more importantly it doesn't introduce a concept we may later regret. So maybe when I re-open a PR for collection operations - I can include a "build list" from multiple input operation?

bgruening commented 8 years ago

Sounds like a plan!

descostesn commented 5 years ago

I still have this problem, any update?