galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

Running workflows: number of <repeat> and <param type="select" multiple="true"> elements cannot be changed #4936

Open Stortebecker opened 7 years ago

Stortebecker commented 7 years ago

Hi. I recognized that it is impossible to add or delete tool params of the type <repeat> or <param type="select" multiple="true"> when running a workflow. Existing params can be changed, but the number cannot be changed without editing the workflow prior to running. This limits the adaptability of premade workflows quite a bit - they have to be re-edited and saved for each different setting!

Here is an example tool: msgfplus excerpt from msgfplus.xml:

        <param name="common_fixed_modifications" type="select" label="Common Fixed Modifications" multiple="true" help="Occurs in known places on peptide sequence. Hold the appropriate key while clicking to select multiple items">
            <option value="C2H3N1O1_C_fix_any_Carbamidomethyl" selected="true">Carbamidomethyl C</option>
            [...]
        </param>

        <param name="common_variable_modifications" type="select" label="Common Variable Modifications" multiple="true" help="Can occur anywhere on the peptide sequence; adds additional error to search score. Hold the appropriate key while clicking to select multiple items">
            [...]
            <option value="O1_M_opt_any_Oxidation" selected="true">Oxidation M</option>
            [...]
        </param>

        <repeat name="custom_mods" title="Custom Modifications" help="Specify modifications with custom parameters">
            [...]

One can define the number of fixed, variable and custom mods via workflow editing: editing_workflow

Number of mods cannot be changed afterwards, when running the workflow: running_workflow

mvdbeek commented 7 years ago

xref: https://github.com/galaxyproject/galaxy/issues/4528. Would indeed be great to allow runtime editing of things that do not add/remove data inputs.

Stortebecker commented 7 years ago

Sorry for the duplicate.