galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.41k stars 1.01k forks source link

Better tool_config_file default in galaxy.ini #502

Closed hexylena closed 8 years ago

hexylena commented 9 years ago

Currently the tool_config_file section of galaxy.ini reads like this:

# Tool config files, defines what tools are available in Galaxy.
# Tools can be locally developed or installed from Galaxy tool sheds.
# (config/tool_conf.xml.sample will be used if left unset and
# config/tool_conf.xml does not exist).
#tool_config_file = config/tool_conf.xml,shed_tool_conf.xml

If you activate that setting by just removing the # from the last line, then, for an otherwise unmodified clone of Galaxy, you're getting an error

  1. because the last entry should be config/shed_tool_conf.xml (include the path)
  2. because Galaxy then stops using config/tool_conf.xml.sample as a fallback if config/tool_conf.xml does not exist
  3. even config/shed_tool_conf.xml does not initially exist

So users have to change three things (add the missing path, and manually copy and rename both tool_conf.xml.sample and shed_tool_conf.xml.sample) to be able to use this line.

Either:

from trello

jmchilton commented 8 years ago

shed_tool_conf.xml -> config/shed_tool_conf.xml has been fixed.

I'm happy with the current state - the default states the sample will be used and if the line is uncommented the sample definitively should not be used in my opinion.

So this is half fixed and half wontfix.