galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.39k stars 1k forks source link

Improve display of queued versus hidden dataset counts on Saved Histories view #5554

Open jennaj opened 6 years ago

jennaj commented 6 years ago

Saved History "Dataset" count icons are colored very similarly (light grey) for both queued and hidden datasets. Different borders, but it is hard to detect the difference unless really zoomed in.

Full screen on a 13" laptop:

screen shot 2018-02-16 at 12 54 39 pm

Zoom:

screen shot 2018-02-16 at 12 55 58 pm
jmchilton commented 6 years ago

Ping @martenson since he helped with the styling on the PR that changed this #5533.

@jennaj Thanks for the quick feedback on this. Any specific advice here what the styling should look like?

Maybe the border color should be black but still dashed? Add another pixel to the depth of the border? The background should be some sort of gradient from white to gray or gray to dark gray?

martenson commented 6 years ago

? screenshot 2018-02-19 12 59 04

martenson commented 6 years ago

with black border screenshot 2018-02-19 13 00 37

(I am not a fan, I think these two states should be the least visible)

jennaj commented 6 years ago

@jmchilton Yes, the simplest solution would be to use a different shade of some grey. If we go with Martin's suggestion above, I would place hidden before deleted in the order.

Grey datasets have indicated queued datasets for a long time. And now the darker grey indicates deleted (deleted or purged). It would be more intuitive to have hidden datasets be some other color but this explodes the icons. Which I like but others may not. We can discuss here for later: https://github.com/galaxyproject/galaxy/issues/5562

martenson commented 6 years ago

@jennaj Could you please lay this out in another issue? The fixes we got into 18.01 were about speeding things up, decoupling, and fixing dataset numbers. Your insights are valuable and they deserve own issue.

jennaj commented 6 years ago

Ok, will do, thanks!