search

galaxyproject / gxadmin

Handy command line utility for Galaxy administrators :rocket:
https://galaxyproject.github.io/gxadmin/#/
GNU General Public License v3.0
23 stars 27 forks source link

Added benchmark for CPU by Tools grouped by Month #118

Closed hujambo-dunia closed 1 year ago

hujambo-dunia commented 1 year ago

Hello, first commit for what we hope can be a "Tool Performance Tracking" suite of queries. Looking for guidance on: (1) query file location (2) max query retrieval size (3) query conventions (output, sample text, validation).

Cc: @hexylena @afgane

afgane commented 1 year ago

I can offer my opinion on (2), which is that we should parameterize the query with dates, similar to this: https://github.com/galaxyproject/usage-metering/blob/4641f91ffe7bc7b7cbc56e2ab9d6bf7817b0f9ea/sql/tool_metrics/jobs.sql#L18. Presumably that can be done via arguments to gxadmin: https://github.com/galaxyproject/gxadmin/blob/main/CONTRIBUTING.md#argument-parsing

(The reason we didn't have that in the current queries is because we pulled the data of interest from the server before invoking the queries: https://github.com/galaxyproject/usage-metering/#extract-job-data-from-a-galaxy-database).

hexylena commented 1 year ago

ok @hujambo-dunia I'm checking the build issues, and, indeed your last PR caused them :sweat_smile:

I'm going to make some fixes for those issues, as well as some others, and will merge this PR shortly.

hexylena commented 1 year ago

I'm...not sure how we merged the previous queries in the past, e.g. variable definitions are wrong (x = "" does not work in bash, it must be x="")