galaxyproject / planemo

Command-line utilities to assist in developing Galaxy and Common Workflow Language artifacts - including tools, workflows, and training materials.
https://planemo.readthedocs.io/
MIT License
89 stars 85 forks source link

Fix use of `package_name` attribute on `CondaTarget` objects #1424

Closed nsoranzo closed 8 months ago

nsoranzo commented 8 months ago

In Galaxy 23.1 galaxy.tool_util.deps.mulled.util.build_target() was changed to return a CondaTarget object instead of a (removed) Target.

To avoid complications, this requires a bump to the galaxy-util and galaxy-tool-util packages to >=23.1 .

Also, add type annotations to most related code.

Fix https://github.com/galaxyproject/galaxy/issues/17378 .

mvdbeek commented 8 months ago

Thank you!

bernt-matthias commented 8 months ago

Thanks a lot @nsoranzo.

Should we unpin the planemo monitor again?

nsoranzo commented 8 months ago

Should we unpin the planemo monitor again?

Yes, I think so.

bernt-matthias commented 8 months ago

ok https://github.com/galaxyproject/planemo-monitor/pull/47