search

galaxyproject / pulsar

Distributed job execution application built for Galaxy
https://pulsar.readthedocs.io
Apache License 2.0
37 stars 50 forks source link

Remove previous wheels before creating a new one. #182

Open VJalili opened 5 years ago

VJalili commented 5 years ago

Since there can be wheels belonging to different version of pulsar already existing in that folder, and since that can cause issues for building docker image as it uses *, hence it would be better to empty the folder of any previous wheels first.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.03%) to 80.711% when pulling 6723f8d68c2f7e81dd6212fe3ecce68cd257f1f0 on VJalili:patch-1 into ddf2fdece779f19d5204db5ea491441821038a5c on galaxyproject:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.03%) to 80.711% when pulling 6723f8d68c2f7e81dd6212fe3ecce68cd257f1f0 on VJalili:patch-1 into ddf2fdece779f19d5204db5ea491441821038a5c on galaxyproject:master.

jmchilton commented 5 years ago

Encountered the same thing, but fixed it by including deleting the wheel in the make dist rule -> make clean.

VJalili commented 5 years ago

@jmchilton both methods seem reasonable to me; we can implement whichever you prefer.

bgruening commented 5 years ago

@VJalili make clean seems to me better.